Reduce slice allocations during unique insertions #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-reduce-allocations
branch
from
e905811 to
9859d7a
Compare
Just reduce some really easy to avoid slice allocations for every unique insertion: * No reason to have `requiredV3states` allocated every time a new unique opts is validated. It never changes. * Leave `missingStates` unallocated by default. Most of the time a unique insertion will have have no missing unique states, so this skips a unique allocation completely the overwhelmingly majority of the time.
brandur
force-pushed
the
brandur-reduce-allocations
branch
from
9859d7a to
d5ed285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just reduce some really easy to avoid slice allocations for every unique
insertion:
No reason to have
requiredV3statesallocated every time a new uniqueopts is validated. It never changes.
Leave
missingStatesunallocated by default. Most of the time aunique insertion will have have no missing unique states, so this
skips a unique allocation completely the overwhelmingly majority of
the time.